This repository was archived by the owner on Jan 7, 2022. It is now read-only.
moved Mohamed Bassem's Prometheus plugin into the LogDevice source tree.#171
Open
march-github wants to merge 2 commits intofacebookarchive:mainfrom
Open
moved Mohamed Bassem's Prometheus plugin into the LogDevice source tree.#171march-github wants to merge 2 commits intofacebookarchive:mainfrom
march-github wants to merge 2 commits intofacebookarchive:mainfrom
Conversation
The plugin implements a StatsPublisher that makes LogDevice stats available to Prometheus over a specified TCP port. For more details see https://github.com/MohamedBassem/logdevice-prometheus. The plugin requires https://github.com/jupp0r/prometheus-cpp/ -- a C++ client library for Prometheus. It is currently pulled from GitHub on every clean build. It would be better to make it a git submodule of LogDevice. The plugin requires no new dependent packages. I changed the cmake options of prometheus-cpp build to remove the dependency on libcurl-dev. Added BUILD_PLUGINS cmake option for LogDevice. Default is ON.
facebook-github-bot
added
the
CLA Signed
If ldprometheus plugin is in the main build, its external dependencies should be handled the same way all other LogDevice external dependencies are. Test plan: Did a clean pull of LogDevice with this change into a new directory. Followed the steps to rebuild LogDevice normally. Verified that build completes and the Prometheus plugin loads fine.
march-github
requested review from
AhmedSoliman,
MohamedBassem and
facebook-github-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin implements a StatsPublisher that makes LogDevice stats
available to Prometheus over a specified TCP port. For more
details see https://github.com/MohamedBassem/logdevice-prometheus.
The plugin requires https://github.com/jupp0r/prometheus-cpp/ -- a
C++ client library for Prometheus. I made it a git submodule
of LogDevice.
The plugin requires no new dependent packages. I changed the cmake options
of prometheus-cpp build to remove the dependency on libcurl-dev.
Added BUILD_PLUGINS cmake option. Default is ON.
Test plan consists of (1) making a clean build of LogDevice with new submodule and plugin, (2) running tests/prometheus_test (passes), and (3) observing that ldprometheus plugin is listed in the output of LD_LOAD_PLUGINS=lib/libldprometheus.so bin/logdeviced.