Easy: Add buck build for assembler #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This introduces a set of changes to the SDDL compiler to support the syntax evolution described in the north-star proposal. While the patch spans multiple layers of the pipeline, the guiding goals are to (1) align the compiler with the updated surface syntax, and (2) make the implementation easier to reason about by removing legacy behavior that no longer maps to the long-term direction. Concretely, the changes focus on the following areas: ## Syntax - Remove symbols that are not supported in the new syntax. - Clarify the boundary between *syntax* and *ops* (ex: `NEG` is not a distinct symbol in the syntax, but it's an op). - Remove unused constructs (e.g. `sym_types`). ## Grammar - Update productions to support operations with _0–1_ LHS arguments and _N_ RHS arguments. ## Parser - Extend parsing logic to match the new arity model (0–1 LHS, N RHS). - General cleanup of `parse_expr`. The refactor aims to reduce the amount of legacy branching and “special-case” behavior in expression parsing. Differential Revision: D92427604
Summary: Adds support for `Bytes(N)` in the new sddl syntax and grammar. This creates a field type with `N` bytes. Differential Revision: D92525900
Summary: I think it’s appropriate to continue representing these in their original “symbol” form—they’re not actually ops. Apologies for the churn. Differential Revision: D92527912
Summary: As titled. Differential Revision: D92713526
|
@daniellerozenblit has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92713526. |
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Feb 9, 2026
Summary: As titled. Differential Revision: D92713526
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Feb 9, 2026
Summary: As titled. Differential Revision: D92713526
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Feb 9, 2026
Summary: As titled. Differential Revision: D92713526
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Feb 10, 2026
Summary: As titled. Differential Revision: D92713526
daniellerozenblit
added a commit
to daniellerozenblit/openzl-1
that referenced
this pull request
Feb 10, 2026
Summary: As titled. Differential Revision: D92713526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled.
Differential Revision: D92713526