Fix "Hash length too large" related decompression fuzzer crashes #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinjzhang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92572732. |
kevinjzhang
added a commit
to kevinjzhang/openzl-1
that referenced
this pull request
Feb 9, 2026
…ebook#378) Summary: Fix fuzzer by returning an `ZL_Error` when reading an invalid contextDepth. This is propagated to the codec which then throws. The alternative is to introduce some error propogation to https://www.internalfb.com/code/fbsource/[239d0d8fa230]/fbcode/openzl/dev/src/openzl/shared/hash.h?lines=117. Also fix a second similar issue for `contextLog` which is only valid for values > 0. Fixes for both dev and prod branches. Differential Revision: D92572732
kevinjzhang
force-pushed
the
export-D92572732
branch
from
63ea0a9 to
462cfd3
Compare
…ebook#378) Summary: Fix fuzzer by returning an `ZL_Error` when reading an invalid contextDepth. This is propagated to the codec which then throws. The alternative is to introduce some error propogation to https://www.internalfb.com/code/fbsource/[239d0d8fa230]/fbcode/openzl/dev/src/openzl/shared/hash.h?lines=117. Also fix a second similar issue for `contextLog` which is only valid for values > 0. Fixes for both dev and prod branches. Differential Revision: D92572732
kevinjzhang
force-pushed
the
export-D92572732
branch
from
462cfd3 to
c45f031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix fuzzer by returning an
ZL_Errorwhen reading an invalid contextDepth. This is propagated to the codec which then throws. The alternative is to introduce some error propogation to https://www.internalfb.com/code/fbsource/[239d0d8fa230]/fbcode/openzl/dev/src/openzl/shared/hash.h?lines=117.Differential Revision: D92572732