Skip graphs with no training samples #367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When I run the protobuf training tool, if we have a proto field that's optional and all samples are missing it then since we iterate over all ACE graphs we will fail (no samples).
I think for optional/rarely-used fields, it's fine to skip and use default compression for those.
Also fixes a bug in the protobuf CLI class where we had
#ifdef ZL_IS_FBCODE. This triggers even ifZL_IS_FBCODE=0, where we should actually check if it's true. This was causing compilation issues for me.Type of Change
Bug fix (non-breaking change which fixes an issue)
Test Plan
protobuf_cli train --input training_data/ --output trained.zlcwhere training_data has all samples missing some proto field