Skip to content

fix!: change adaptor -> adapter for consistency#452

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency
Feb 17, 2026
Merged

fix!: change adaptor -> adapter for consistency#452
wschurman merged 1 commit intomainfrom
wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 16, 2026

Why

As part of #451, claude noticed that we used both american and british english variants of "adapter"/"adaptor". This makes them consistent by making them all "adapter".

How

Update name. Technically this is a breaking change but the nature of the library allows tsc to catch it in all application code that uses the library.

Test Plan

yarn tsc

Copy link
Member Author

wschurman commented Feb 16, 2026

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c933db1) to head (6d44ba1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #452   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines        16006     16006           
  Branches       861       861           
=========================================
  Hits         16006     16006           
Flag Coverage Δ
integration 23.35% <0.00%> (ø)
unittest 95.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman force-pushed the wschurman/02-16-chore_docblock_improvements branch from 2109394 to 364a3bd Compare February 17, 2026 16:38
@wschurman wschurman force-pushed the wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency branch from 674d84f to 2175ffe Compare February 17, 2026 16:38
@wschurman wschurman requested review from ide and quinlanj February 17, 2026 17:08
@wschurman wschurman marked this pull request as ready for review February 17, 2026 17:08
Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a brief line to CLAUDE.md saying to prefer this spelling?

@wschurman wschurman force-pushed the wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency branch from 2175ffe to 5efa7c1 Compare February 17, 2026 22:31
@wschurman wschurman force-pushed the wschurman/02-16-chore_docblock_improvements branch from 364a3bd to 83d672e Compare February 17, 2026 22:31
@wschurman wschurman force-pushed the wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency branch from 5efa7c1 to 084bd11 Compare February 17, 2026 22:35
Copy link
Member Author

wschurman commented Feb 17, 2026

Merge activity

  • Feb 17, 10:40 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 17, 10:46 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 17, 10:48 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-16-chore_docblock_improvements to graphite-base/452 February 17, 2026 22:41
@wschurman wschurman changed the base branch from graphite-base/452 to main February 17, 2026 22:44
@wschurman wschurman force-pushed the wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency branch from 084bd11 to 6d44ba1 Compare February 17, 2026 22:45
@wschurman wschurman merged commit 517d57b into main Feb 17, 2026
5 checks passed
@wschurman wschurman deleted the wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency branch February 17, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments