Skip to content

chore: move knex-specific loader logic out of EntityDataManager#408

Merged
wschurman merged 1 commit intomainfrom
wschurman/01-30-chore_move_knex-specific_loader_logic_out_of_entitydatamanager
Feb 9, 2026
Merged

chore: move knex-specific loader logic out of EntityDataManager#408
wschurman merged 1 commit intomainfrom
wschurman/01-30-chore_move_knex-specific_loader_logic_out_of_entitydatamanager

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Jan 31, 2026

Why

Part 2 of #407.

How

Refactor methods into a separate class for future move out of main package.

Test Plan

Full test coverage.

Copy link
Member Author

wschurman commented Jan 31, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wschurman wschurman force-pushed the wschurman/01-30-chore_move_knex-specific_loader_logic_out_of_entitydatamanager branch 3 times, most recently from ee57e84 to 0be9f1d Compare January 31, 2026 17:15
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2590b95) to head (e228d66).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #408    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           96        97     +1     
  Lines        13144     13171    +27     
  Branches      1119       665   -454     
==========================================
+ Hits         13144     13171    +27     
Flag Coverage Δ
integration 6.96% <0.00%> (-0.02%) ⬇️
unittest 97.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed - the plan is to merge the stack and then follow up by adding "loadOne" or "loadFirst" functionality to all loaders, and EntityPrivacyUtils will be independent of Knex.

@wschurman wschurman force-pushed the wschurman/01-30-chore_move_knex-specific_loader_logic_out_of_entitydatamanager branch from 733b363 to b1423c1 Compare February 9, 2026 23:28
@wschurman wschurman force-pushed the wschurman/01-30-feat_move_knex-specific_loader_methods_to_knexloader branch from a0423c5 to 00bb4a7 Compare February 9, 2026 23:28
Copy link
Member Author

wschurman commented Feb 9, 2026

Merge activity

  • Feb 9, 11:36 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 9, 11:38 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 9, 11:40 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/01-30-feat_move_knex-specific_loader_methods_to_knexloader to graphite-base/408 February 9, 2026 23:36
@wschurman wschurman changed the base branch from graphite-base/408 to main February 9, 2026 23:36
@wschurman wschurman force-pushed the wschurman/01-30-chore_move_knex-specific_loader_logic_out_of_entitydatamanager branch from b1423c1 to e228d66 Compare February 9, 2026 23:37
@wschurman wschurman merged commit 567bb61 into main Feb 9, 2026
3 checks passed
@wschurman wschurman deleted the wschurman/01-30-chore_move_knex-specific_loader_logic_out_of_entitydatamanager branch February 9, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments