Open
Conversation
|
Subscribed to pull request
Generated by CodeMention |
hooks schema
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3408 +/- ##
==========================================
+ Coverage 52.54% 52.55% +0.01%
==========================================
Files 806 806
Lines 33610 33616 +6
Branches 6985 6986 +1
==========================================
+ Hits 17657 17663 +6
Misses 15871 15871
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hookstype/schema with reusable Zod/Joi validation so any string key maps to step arraysNot sure if it makes sense to make this "smart". I think let's just roll this out manually? Like, have
eas/install_node_modulessteps be sort of manually wrapped with hooks? Or maybe we'll sprinkle them when parsing the steps. I'll see. What I think is right is not to limit the keys to only a few known values.Test plan
CI should pass.