Skip to content

[eas-build-job] Add hooks schema#3408

Open
sjchmiela wants to merge 2 commits intomainfrom
stanley/add-hooks-definition-to-easbuildjb
Open

[eas-build-job] Add hooks schema#3408
sjchmiela wants to merge 2 commits intomainfrom
stanley/add-hooks-definition-to-easbuildjb

Conversation

@sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Feb 17, 2026

Summary

  • introduce a shared Hooks type/schema with reusable Zod/Joi validation so any string key maps to step arrays
  • wire the new hooks definition through the generic, Android, and iOS job schemas and exports
  • expand existing tests to cover accepting arbitrary hook names, empty hook arrays, and invalid hook step payloads

Not sure if it makes sense to make this "smart". I think let's just roll this out manually? Like, have eas/install_node_modules steps be sort of manually wrapped with hooks? Or maybe we'll sprinkle them when parsing the steps. I'll see. What I think is right is not to limit the keys to only a few known values.

Test plan

CI should pass.

@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sjchmiela sjchmiela changed the title Add extensible hooks definition to eas build jobs [eas-build-job] Add hooks schema Feb 17, 2026
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Feb 17, 2026
@github-actions
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela sjchmiela requested a review from douglowder February 17, 2026 21:21
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.55%. Comparing base (50b9be9) to head (2d7e199).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3408      +/-   ##
==========================================
+ Coverage   52.54%   52.55%   +0.01%     
==========================================
  Files         806      806              
  Lines       33610    33616       +6     
  Branches     6985     6986       +1     
==========================================
+ Hits        17657    17663       +6     
  Misses      15871    15871              
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant