Skip to content

Add explicit Gym container selection and pod scheme guard#3407

Open
sjchmiela wants to merge 2 commits intomainfrom
stanley/prevent-pod-name-conflict-build
Open

Add explicit Gym container selection and pod scheme guard#3407
sjchmiela wants to merge 2 commits intomainfrom
stanley/prevent-pod-name-conflict-build

Conversation

@sjchmiela
Copy link
Contributor

Summary

  • ensure fastlane resolves an explicit workspace/project before generating Gymfiles, via a deterministic container helper
  • guard both eas-cli and build-tools against Pod shared schemes that share the app scheme name with user-facing guidance on remediation
  • cover new helpers with unit tests for Gymfile output and collision detection

Testing

  • Not run (not requested)

@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.41%. Comparing base (2655482) to head (d908db1).

Files with missing lines Patch % Lines
packages/eas-cli/src/project/ios/scheme.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3407      +/-   ##
==========================================
+ Coverage   52.39%   52.41%   +0.02%     
==========================================
  Files         803      804       +1     
  Lines       33445    33461      +16     
  Branches     6970     6972       +2     
==========================================
+ Hits        17521    17536      +15     
- Misses      15842    15843       +1     
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Feb 17, 2026
@github-actions
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments