Open
Conversation
|
Size Change: +3.21 kB (0%) Total Size: 72.7 MB
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## stanley/add-log-id #3391 +/- ##
======================================================
- Coverage 52.31% 52.24% -0.06%
======================================================
Files 804 805 +1
Lines 33425 33490 +65
Branches 6975 6986 +11
======================================================
+ Hits 17482 17493 +11
- Misses 14555 14602 +47
- Partials 1388 1395 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjchmiela
force-pushed
the
stanley/http-logger
branch
from
094096c to
19ec631
Compare
sjchmiela
force-pushed
the
stanley/http-logger
branch
from
60d6b13 to
bdf49ab
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention |
|
|
||
| if (config.loggers.http.baseUrl && robotAccessToken) { | ||
| const httpLogStream = new HttpLogStream({ | ||
| url: new URL(config.buildId, config.loggers.http.baseUrl).toString(), |
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
or that is intentional to make this PR noop?
AbbanMustafa
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We want to push logs to a logs service.
How
Initially I wanted to set up a WebSocket connection between worker and the logs service to reduce the HTTP overhead, but I found having a persistent/reconnecting WebSocket connection is not trivial and HTTP should be ok.
Confirmed failure to upload is not logged in the GCS log.
Test Plan
Tested manually.
Nagranie.z.ekranu.2026-02-10.o.10.28.42.mov