Conversation
|
Subscribed to pull request
Generated by CodeMention |
|
Size Change: +9.29 kB (+0.02%) Total Size: 57.5 MB
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3376 +/- ##
==========================================
- Coverage 49.60% 49.30% -0.30%
==========================================
Files 676 677 +1
Lines 28544 28814 +270
Branches 5936 5980 +44
==========================================
+ Hits 14157 14204 +47
- Misses 13171 13378 +207
- Partials 1216 1232 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return { projectArchiveBucketKey, easJsonBucketKey, packageJsonBucketKey }; | ||
| }); | ||
|
|
||
| const { id: workflowRunId } = await WorkflowRunMutation.createWorkflowRunAsync(graphqlClient, { |
There was a problem hiding this comment.
If we use the regular workflow run flow, free users will end up in the free tier queue and paid users will pay for Expo Go build.
I think in v0.1 we may want to have a dedicated mutation for all this (with static workflow YAML managed in www, priority = high, waivedAt = NOW()).
| ]; | ||
|
|
||
| if (!customizeCreds) { | ||
| prompts.inject(Array(20).fill(true)); |
There was a problem hiding this comment.
Claude's invention how to use defaults for credentials 🙈
I will see if I can customize it better
| analytics, | ||
| vcsClient, | ||
| easJsonCliConfig: { | ||
| promptToConfigurePushNotifications: false, |
There was a problem hiding this comment.
Should we prompt for push notifications setup? Do we want this Expo Go to have notifications? Maybe that's not the goal here?
There was a problem hiding this comment.
Ideally we would preserve all behavior but if there's any issue with push notifications we are fine dropping them I think
There was a problem hiding this comment.
I am not sure. We are probably fine with notifications missing if that would block us otherwise
There was a problem hiding this comment.
i'm fine with skipping notifications. although if we already added support for the notification extension when repacking, then maybe it's worth prompting for this
|
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
3 participants
Why
We want to give users an option to create custom Expo Go builds in CLI.
How
Using a mix of existing commands.
Note: the release build of Expo Go for SDK 55 is hardcoded right now, together with version numbers.
Test Plan
Ran locally several times. Expected behavior: user is authenticated with their apple developer account, repack & TestFlight jobs run, after processing Apple sends a TestFlight invite email.