Support casting config values as dict with pydantic (#54)#55
Open
percevalw wants to merge 1 commit intoexplosion:mainfrom
Open
Support casting config values as dict with pydantic (#54)#55percevalw wants to merge 1 commit intoexplosion:mainfrom
percevalw wants to merge 1 commit intoexplosion:mainfrom
Conversation
Contributor
|
Thanks for the PR, we'll take a closer look soon! |
percevalw
force-pushed
the
fix-dict-casting
branch
from
52c1faa to
685ae2f
Compare
percevalw
force-pushed
the
fix-dict-casting
branch
from
685ae2f to
cbd7f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
This PR should fix #54. We just have to verify that the destination is a dict when recursively updating a Config field, and overwrite the destination with the new value otherwise.