feat: Added possibility for shared numbering of theorems. #164
+183
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted the translated type title into a separate variable for clarity before constructing the title node in ProofDomain.
Introduces a check_config_values function to validate Sphinx configuration values at runtime, ensuring correct types and defaults for proof-related settings. Also refactors DEFAULT_REALTYP_TO_COUNTERTYP in directive.py to dynamically use PROOF_TYPES, improving maintainability and consistency.
Refactored the definition of DEFAULT_REALTYP_TO_COUNTERTYP from directive.py to proof_type.py for better separation of concerns and to avoid circular imports. Updated imports accordingly. Minor changes to test files only add missing newlines at end of file.
for more information, see https://pre-commit.ci
Moved the DEFAULT_REALTYP_TO_COUNTERTYP dictionary from proof_type.py directly into directive.py to remove the import and simplify dependencies. Updated test HTML and LaTeX files to ensure proper newline at end of file.
…hinx-proof into Ljon4ik4-main
Relocated the DEFAULT_REALTYP_TO_COUNTERTYP mapping from directive.py to proof_type.py for better modularity and to centralize proof type definitions.
Relocated the DEFAULT_REALTYP_TO_COUNTERTYP dictionary from proof_type.py to directive.py to improve module organization and reduce unnecessary imports.
Replaces the hardcoded DEFAULT_REALTYP_TO_COUNTERTYP dictionary with a dynamic construction based on PROOF_TYPES from proof_type.py. This improves maintainability by centralizing proof type definitions.
Replaces dynamic construction of DEFAULT_REALTYP_TO_COUNTERTYP from PROOF_TYPES with a static dictionary definition. This change removes the dependency on PROOF_TYPES and makes the mapping explicit within directive.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optioin to have directives share numbering. Reflected also in docs.