Conversation
- Update backend, frontend, and root package.json versions to 0.7.0 - Add classes array to NodeHieraData and NodeHieraDataResponse types - Modify classifyKeyUsage method to return included classes alongside used/unused keys - Replace getNodeCatalog with getNodeResources for more reliable class extraction - Extract Class resources directly from resourcesByType instead of filtering catalog - Update HieraService to include classes in node Hiera data response - Include classes in API response for NodeHieraTab component consumption - Improve logging to show all classes found instead of just examples - Add warning log when no Class resources are found for debugging purposes - Update Navigation component to display v0.7.0 version number
- Fix date range calculation to include today in the requested number of days instead of adding an extra day - Change end date to current moment instead of end of day to show partial data for today - Adjust start date calculation from `days` to `days - 1` to properly include today in the count - Normalize end date to start of day when comparing dates to prevent off-by-one errors - Add debug logging for date range and converted history length - Update all test expectations to reflect correct day counts (e.g., 7 days returns 7 days, not 8) - Add found/not-found filter state to NodeHieraTab component for better data filtering - This fixes the inconsistency where requesting N days of history would return N+1 days
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the version from 0.6.0 to 0.7.0 and includes improvements to Hiera class detection, date range handling in Puppet run history, and UI enhancements.
Changes:
- Version updated to 0.7.0 across all package.json files and UI display
- Improved Hiera service to use PuppetDB resources API for more reliable class extraction
- Fixed date range calculation in PuppetRunHistoryService to correctly handle "last N days including today"
- Enhanced Hiera UI with better filtering options (usage vs resolution status) and collapsible class display
- Added dark mode text styling to HomePage title
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bump to 0.7.0 |
| frontend/package.json | Version bump to 0.7.0 |
| backend/package.json | Version bump to 0.7.0 |
| frontend/src/components/Navigation.svelte | Version display updated to 0.7.0 (also fixes spacing typo) |
| frontend/src/pages/HomePage.svelte | Added dark mode text color classes for better visibility |
| backend/src/integrations/hiera/types.ts | Added optional classes field to NodeHieraData and NodeHieraDataResponse interfaces |
| backend/src/routes/hiera.ts | Included classes array in API response |
| backend/src/integrations/hiera/HieraService.ts | Switched from getNodeCatalog to getNodeResources for more reliable class extraction, now returns classes array |
| frontend/src/components/NodeHieraTab.svelte | Major UI refactoring: separated usage and resolution filters, added collapsible classes display section, improved labeling |
| backend/src/services/PuppetRunHistoryService.ts | Fixed date range logic to correctly calculate "last N days including today" (changed from N+1 to N days) |
| backend/test/services/PuppetRunHistoryService.test.ts | Updated test expectations to match corrected date range logic (8→7, 4→3 days) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.