Draft
Conversation
Member
Author
|
@chfast apparently instead of this mess we do in the install scripts, the WAVM author suggests the following: WAVM/WAVM#128 I'm not versed in cmake at all to know if that helps. Can you check? |
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 51.18% 52.17% +0.98%
==========================================
Files 8 8
Lines 1346 1311 -35
Branches 130 129 -1
==========================================
- Hits 689 684 -5
+ Misses 630 600 -30
Partials 27 27 |
axic
force-pushed
the
wavm-update
branch
2 times, most recently
from
0dbae10 to
d4e36cd
Compare
Collaborator
This will not work in our case unless you add it to Hunter. |
axic
force-pushed
the
wavm-update
branch
4 times, most recently
from
71f3068 to
114cd89
Compare
Member
Author
|
@chfast can you review this? My only requirement for this PR would be that we do not have larger memory leak due to our code than before. |
Member
Author
|
This is broken after the rebase 😢 |
axic
force-pushed
the
wavm-update
branch
2 times, most recently
from
98c9944 to
c4155dc
Compare
c1d2ba94 from 7th Feb 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.