chore: remove PANDAOPS ENV variables from docker compose#380
Open
Ktl-XV wants to merge 1 commit intoethereum:masterfrom
Open
chore: remove PANDAOPS ENV variables from docker compose#380Ktl-XV wants to merge 1 commit intoethereum:masterfrom
Ktl-XV wants to merge 1 commit intoethereum:masterfrom
Conversation
kdeme
reviewed
Mar 18, 2025
Contributor
kdeme
left a comment
kdeme
left a comment
There was a problem hiding this comment.
I am all for removing these pandaops specifics but I think this version will not get accepted as it will render the docker compose file not usable for pandaops if I'm not mistaken.
As explained in this issue #357: The code currently relies on using that specific pandaops version of the command so that the right headers get injected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanding on PR #356 to include a change and documentation on how to run the beacon monitor with a custom beacon node API