Conversation
Contributor
Author
|
@ethanblake4 any objections to the proposal? 😇 |
Owner
|
Thanks, that's a great idea. The only potential issue is that it is replacing all synchronous file I/O with async file I/O which is slower, and in the case of HotSwapLoader which actually blocks your whole app from loading until the runtime has been created, this could cause a slower start-up time. The amount of time might be irrelevant, but I'd appreciate if you could test that (a basic test program that just tests sync and async loading speed of a standard EVC file is fine) just in case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
EvcLoaderand its implementations for asset, file, http fetching to:Docs to be added/updated, just let me know if there's something I've missed in the current implementation first 😇