Fix(esx_identity/server/main.lua): Added esx_identity:completedRegistration event within if statement xPlayer#1763
Open
kizzwell wants to merge 1 commit intoesx-framework:devfrom
Open
Fix(esx_identity/server/main.lua): Added esx_identity:completedRegistration event within if statement xPlayer#1763kizzwell wants to merge 1 commit intoesx-framework:devfrom
kizzwell wants to merge 1 commit intoesx-framework:devfrom
Conversation
…tement to ensure that the event is being triggered according to the Official Documentation
Contributor
|
@CliqueDev25 in order for us to be able to merge it u must agree to our CLA (https://cla-assistant.io/esx-framework/esx_core?pullRequest=1763 ) |
Author
|
@Arctos2win I now have accepted the license/cla. |
Contributor
Hi, I have put someone within the team on refactoring esx_identity, Thanks for pointing this issue out ! Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix ensures that the esx_identity:completedRegistration according to the official documentations gets triggered after a player completed their registration.
Motivation
This would help players to identify if the player has completed their registration and be able to integrate their own scripts to the framework regarding registration.
Implementation Details
Added the event trigger inside the if statement which was not being triggered due to returning early if xPlayer exists.
PR Checklist