Fix<esx_identity>: esx_identity:completedRegistration event trigger#1762
Closed
kizzwell wants to merge 1 commit intoesx-framework:mainfrom
Closed
Fix<esx_identity>: esx_identity:completedRegistration event trigger#1762kizzwell wants to merge 1 commit intoesx-framework:mainfrom
kizzwell wants to merge 1 commit intoesx-framework:mainfrom
Conversation
…. Previously being blocked due to returning value if xPlayer exists
|
|
|
Thanks for your contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not triggering esx_identity:completedRegistration correctly
Description
Added esx_identity:completedRegistration inside xPlayer condition.
The original event isn't being triggered if xPlayer exists which renders this event unusable.
Motivation
Documentation does include this event but doesn't get triggered properly.
Adding this would allow people to make a listener after the registration.
PR Checklist