Skip to content

Fix<esx_identity>: esx_identity:completedRegistration event trigger#1762

Closed
kizzwell wants to merge 1 commit intoesx-framework:mainfrom
kizzwell:main
Closed

Fix<esx_identity>: esx_identity:completedRegistration event trigger#1762
kizzwell wants to merge 1 commit intoesx-framework:mainfrom
kizzwell:main

Conversation

@kizzwell
Copy link

@kizzwell kizzwell commented Dec 1, 2025

Not triggering esx_identity:completedRegistration correctly

Description

Added esx_identity:completedRegistration inside xPlayer condition.
The original event isn't being triggered if xPlayer exists which renders this event unusable.


Motivation

Documentation does include this event but doesn't get triggered properly.
Adding this would allow people to make a listener after the registration.

PR Checklist

  • [✅] My commit messages and PR title follow the Conventional Commits standard.
  • [✅] My changes have been tested locally and function as expected.
  • [✅] My PR does not introduce any breaking changes.
  • [✅] I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

…. Previously being blocked due to returning value if xPlayer exists
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Zuntie
Copy link

Zuntie commented Dec 1, 2025

Thanks for your contribution :)
Please make the pull request target the dev branch, instead of the main branch.

@kizzwell kizzwell closed this by deleting the head repository Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants