feat: add esx_halloween#90
Open
simpleC0de wants to merge 13 commits intoesx-framework:halloween_event_addonsfrom
Open
feat: add esx_halloween#90simpleC0de wants to merge 13 commits intoesx-framework:halloween_event_addonsfrom
simpleC0de wants to merge 13 commits intoesx-framework:halloween_event_addonsfrom
Conversation
Zykem
requested changes
Oct 23, 2025
Zykem
reviewed
Oct 23, 2025
Zykem
reviewed
Oct 23, 2025
Zykem
reviewed
Oct 23, 2025
Zykem
reviewed
Oct 23, 2025
… correct ESX.GetPlayer
Zykem
reviewed
Oct 23, 2025
Zykem
reviewed
Oct 23, 2025
Zykem
requested changes
Oct 27, 2025
| end | ||
| end | ||
| end | ||
| end) |
Contributor
There was a problem hiding this comment.
Both these threads should not be having an infinite loop.
Start the threads whenever player is becoming a ghost and do conditional while loop, such as:
while ghostState.isGhost do
|
|
||
| -- Clear timeouts | ||
| if ghostRequestTimeout then | ||
| ClearTimeout(ghostRequestTimeout) |
Contributor
There was a problem hiding this comment.
ClearTimeout is not working in fivem's environment.
For every usage of SetTimeout and ClearTimeout, replace it with ESX.SetTimeout and ESX.ClearTimeout please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces esx_halloween, a complete Halloween event system that adds immersive ghost gameplay to ESX Legacy servers. When players die, they have a chance to return as ghosts with special abilities including increased movement speed, partial invisibility, and the ability to scare nearby players with jumpscare effects.
The resource includes a modern Svelte 5-based UI with smooth animations, comprehensive admin controls, and a flexible notification system themed for Halloween events. All components are production-ready with full server-side validation, performance optimizations, and ESX theme integration.
Motivation
ESX Legacy currently lacks seasonal event systems that can engage players during special occasions. This Halloween addon provides servers with a ready-to-use event system that:
The ghost system creates memorable player interactions while respecting server performance and preventing exploits through strict server-side validation.
Implementation Details
Core Architecture:
shared/events.luato prevent naming conflictsSecurity Features:
Performance Optimizations:
UI/UX:
Database:
Usage Example
Configuration:
PR Checklist