Improve ESTER chemistry fixing freeeos implementation#13
Open
ctmbl wants to merge 20 commits intoester-project:masterfrom
Open
Improve ESTER chemistry fixing freeeos implementation#13ctmbl wants to merge 20 commits intoester-project:masterfrom
ctmbl wants to merge 20 commits intoester-project:masterfrom
Conversation
849a02a to
f5f7d25
Compare
…the remaining of the sum of fractions
…ost import isotops
…t in fill/read, remove useless redondant init_comp
…ers comp in stard::init_comp
… old initial_composition
This reverts commit 208454b.
Contributor
Author
|
I'll publish here, and edit the TODO list whenever I progress in this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap:
initial_compositionfuncion and introduce newstar2d::init_metal_mix(85d8c3d)star2d::fillandstar2d::init_compand ensure it (85d8c3d)-mixt <mixt>flag, where<mixt>is either a default mixture (GN93, GS98...) or a file describing a custom one (via relative metal fractions of Z)-Zstar2d.compattribute to hdf5 file (easy)-composition <comp.cfg>describing an absolute metal composition in log(n_i/n_H)-Zor-mixt-composition,-Zor-mixtwith-i <input model>-mixtand-i: keep same Z as input model and change metal mixture-Zand-i: keep same mixture and change metals absolute fractions, Y compensate the surplus/loss of metals to ensure X+Y+Z=1-mixtand-Z) OR-composition) and-i: keep nothing, change mixture and Z, Y compensateTODO:
star2d.comp-attribute internal metal composition (other usescomp.X|Y|Z()methods) but uses badly (dpeends on basically the whole roadmap) (2f750de, ...)ester_infostar1dstar2d(optionallystar*dRandester_evol) works correctlyatm_onelayerto avoid calling eos resolution inside the loop (?)Notes:
star.hstar.h@rieutord