Add parentheses for Python 3 print function in ester-check-models

[warrickball]

I recently installed ESTER successfully using the instructions in the top-level INSTALL file, i.e. in the ESTER folder,

$ ./bootstrap
$ ./configure --prefix=~/.local LIBS="-lpython3.10"
$ make -j 4
$ make install

worked.

I then noticed that the ester-check-models script returned syntax errors because there weren't parentheses in some of the print statements, which are required for Python 3. e.g.,

$ ester-check-models
  File "/home/wball/.local/bin/ester-check-models", line 138
    print "[Failed]"
    ^^^^^^^^^^^^^^^^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?

I think I correctly inferred how the ester-check-models script is generated and have modified that file to include the missing parentheses.

The Wiki says I should open the PR against dev, rather than master, but master has been updated more recently and the Wiki was last modified in 2015. I'm happy to change the target to dev.

[rieutord]

Hi Warrick, Thanks for let us know this bug (which actually comes from the original use of python 2.7 I'll have a look. Best wishes, Michel ***************************************************************************** Prof. Michel Rieutord Institut de Recherche en Astrophysique et Planétologie Université Paul Sabatier et Observatoire Midi-Pyrénées email : ***@***.*** 14 avenue Edouard Belin Tel +33 -(0)5 61 33 29 49 31400 Toulouse, France Fax +33 -(0)5 61 33 28 40 ***************************************************************************** Le 22/03/2022 à 16:51, Warrick Ball a écrit :

…

I recently installed ESTER successfully using the instructions in the top-level |INSTALL| file, i.e. in the ESTER folder, |$ ./bootstrap $ ./configure --prefix=~/.local LIBS="-lpython3.10" $ make -j 4 $ make install | worked. I then noticed that the |ester-check-models| script returned syntax errors because there weren't parentheses in some of the |print| statements, which are required for Python 3. e.g., |$ ester-check-models File "/home/wball/.local/bin/ester-check-models", line 138 print "[Failed]" ^^^^^^^^^^^^^^^^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)? | I think I correctly inferred how the |ester-check-models| script is generated and have modified that file to include the missing parentheses. The Wiki says <https://github.com/ester-project/ester/wiki/Contributing> I should open the PR against |dev|, rather than |master|, but |master| has been updated more recently and the Wiki was last modified in 2015. I'm happy to change the target to |dev|. ------------------------------------------------------------------------ You can view, comment on, or merge this pull request online at: #12 Commit Summary * fcc60a6 <fcc60a6> Add parentheses for Python 3 print function in ester-check-models File Changes (1 file <https://github.com/ester-project/ester/pull/12/files>) * *M* test/models/test_models.in <https://github.com/ester-project/ester/pull/12/files#diff-0357963d9ad0195a54b9d9f10bddf20b16ce0974f1c2d5e00c2df9c3fba21997> (20) Patch Links: * https://github.com/ester-project/ester/pull/12.patch * https://github.com/ester-project/ester/pull/12.diff — Reply to this email directly, view it on GitHub <#12>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFVG4MEKJNBENNVVKN7QDLVBHT6VANCNFSM5RLKHB4A>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>