Type improvements #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 73.98% 74.01% +0.02%
==========================================
Files 7 7
Lines 1188 1193 +5
Branches 169 169
==========================================
+ Hits 879 883 +4
- Misses 309 310 +1 ☔ View full report in Codecov by Sentry. |
This can help avoid doing too often `[exml:element() | exml:cdata()]` in specs.
NelsonVides
force-pushed
the
type_improvements
branch
from
db13efd to
9123113
Compare
DenysGonchar
approved these changes
Jan 27, 2025
DenysGonchar
left a comment
DenysGonchar
left a comment
There was a problem hiding this comment.
looks good, thanks for removing outdated attr type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit really should be merged, as strong typing tools return warnings because the spec declared it is anything but we always use it as
iodata(). The second commit was just me thinking that everywhere we deal with binaries, so why only here it is a list, we can use binaries for this too.