Remove unused parameters causing compilation errors#8
Open
bkoski wants to merge 1 commit intoericboesch:masterfrom
Open
Remove unused parameters causing compilation errors#8bkoski wants to merge 1 commit intoericboesch:masterfrom
bkoski wants to merge 1 commit intoericboesch:masterfrom
Conversation
|
On Mac OS Sequoia (15.0.1) impossible to compile When i run This PR fix the compilation 🥳🥳🥳🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #7, installations currently error because the parameter counts in
rb_bitset_sizeandrb_bitset_reversedon't match the parameter counts mentioned later on inrb_define_method:Since these parameters appear to be unused, this PR removes them from the function definitions. Verified that this resolves the installation problem on MacOS ruby 3.x.