Update rules_go calls to match Envoy WORKSPACE#81
Open
isaacd9 wants to merge 1 commit intoenvoyproxy:mainfrom
Open
Update rules_go calls to match Envoy WORKSPACE#81isaacd9 wants to merge 1 commit intoenvoyproxy:mainfrom
isaacd9 wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Isaac Diamond <isaacd9@gmail.com>
2a49090 to
2ca9f3e
Compare
TonyDou
approved these changes
Mar 12, 2019
TonyDou
left a comment
There was a problem hiding this comment.
yay, it fixes the build break in this repo.
TonyDou
approved these changes
May 31, 2019
TonyDou
left a comment
There was a problem hiding this comment.
This fixed the build build in the current example filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when trying to build the
//:envoytarget as described in the README, the build fails immediately with:This PR updates the
rules_godirectives in theWORKSPACEof this repository to match those of Envoy at HEAD of master and should fix the build.