Open
Conversation
Signed-off-by: helight <helightxu@tencent.com>
7e65013 to
2831af1
Compare
Author
|
@lizan please help to review this pr |
lizan
reviewed
Sep 30, 2020
Member
lizan
left a comment
There was a problem hiding this comment.
Can we have some sort of test for this config? Like verify examples in envoy repo.
| typed_config: | ||
| "@type": type.googleapis.com/sample.Decoder | ||
| key: via | ||
| key: Via |
Author
There was a problem hiding this comment.
This is just for testing this function
http_filter.cc
const LowerCaseString HttpSampleDecoderFilter::headerKey() const {
return LowerCaseString(config_->key());
}
Author
Ok |
Signed-off-by: helight <helightxu@tencent.com>
4d6287a to
23a01a4
Compare
Author
@lizan I add a startup.sh and verify.sh, please help to check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.