Implement portal screenshot creation#142

Open

TornaxO7 wants to merge 34 commits intomainfrom

91-x11-backendcreate_screenshots-creates-blank-screenshots

Collaborator

TornaxO7 commented Apr 4, 2024

No description provided.

TornaxO7 added 4 commits

February 25, 2024 13:59


          adding zbus4 dependency

74444a3


          updating flake dependencies

2534aea


          moving x11.rs to extra directory

d3eb103


          first trying demo

38afe4d

TornaxO7 linked an issue

that may be closed by this pull request

X11: backend::create_screenshots creates blank screenshots #91

Open

TornaxO7 marked this pull request as draft

April 4, 2024 18:38

TornaxO7 added 4 commits

April 4, 2024 22:12


          finish code of portal

6d1f45a


          adding docs

c79887f


          update

de9ea04


          make clippy happy

c0963e6

TornaxO7 marked this pull request as ready for review

April 4, 2024 20:46


          removing unused file

8b1d1ee

TornaxO7 changed the title ~~Implement dbus backend~~ Implement portal screenshot creation

Collaborator Author

TornaxO7 commented Apr 4, 2024 •

edited

Loading

Why is the CI stuck?

TornaxO7 added 2 commits

April 4, 2024 22:59


          fixing Cargo.lock version conflict

343558a


          Merge branch 'main' into 91-x11-backendcreate_screenshots-creates-bla…

f0eaf1e

…nk-screenshots

TornaxO7 requested a review from eneoli

April 4, 2024 21:06


          Merge branch 'main' of github.com:eneoli/flakeshot into 91-x11-backen…

ef7e875

…dcreate_screenshots-creates-blank-screenshots

eneoli reviewed

View reviewed changes

Cargo.toml Show resolved Hide resolved

eneoli reviewed

View reviewed changes

src/backend/x11/fallback.rs Outdated Show resolved Hide resolved

eneoli reviewed

View reviewed changes

src/backend/x11/fallback.rs Outdated Show resolved Hide resolved

eneoli reviewed

View reviewed changes

src/backend/x11/mod.rs Outdated Show resolved Hide resolved

eneoli reviewed

View reviewed changes

src/backend/x11/mod.rs Outdated Show resolved Hide resolved

eneoli requested changes

View reviewed changes

Owner

eneoli left a comment

see comments

TornaxO7 added 2 commits

May 29, 2024 22:12


          Merge branch 'main' into 91-x11-backendcreate_screenshots-creates-bla…

3889a01

…nk-screenshots


          update Cargo.lock

fdb411e

Collaborator Author

TornaxO7 commented May 29, 2024

hm... ok, after reading through your comments, I think that there has been a missunderstanding. I thought that we only want to use the portal if the user is on X11 and GNOME or KDE. Will fix it 👍

TornaxO7 marked this pull request as draft

August 11, 2024 09:02

TornaxO7 added 2 commits

August 12, 2024 13:07


          Merge branch 'main' of github.com:eneoli/flakeshot into 91-x11-backen…

6642d98

…dcreate_screenshots-creates-blank-screenshots


          update flake

e5f0526

TornaxO7 added 9 commits

August 12, 2024 13:10


          update rust-toolchain

b3f8881


          move portal as third option

92aa76e


          Merge branch 'main' of github.com:eneoli/flakeshot into 91-x11-backen…

f81b121

…dcreate_screenshots-creates-blank-screenshots


          Merge branch 'main' into 91-x11-backendcreate_screenshots-creates-bla…

dac9f01

…nk-screenshots


          x11: apply portal changes

68fc92b


          simplify wayland

4b2681e


          implement portal for wayland

2273d43


          x11: add docs

dfcc56f


          wayland: update docs

5868ec2

TornaxO7 marked this pull request as ready for review

November 7, 2024 21:04

TornaxO7 added 5 commits

November 7, 2024 22:25


          fix ci

46e8d38


          Revert "fix ci"

30f137c

This reverts commit 46e8d38.


          bump nix ci version

a017b76


          Revert "bump nix ci version"

84c2491

This reverts commit a017b76.


          action.yml: bump nix version of ci

0c17d26

TornaxO7 requested a review from eneoli

November 7, 2024 21:36


          removing helix directory :>

Collaborator Author

TornaxO7 commented Nov 7, 2024 •

edited

Loading

Note: I only tested this on Xorg and it works for me (tested on KDE (with portals :D) and i3 with cargo run -- -l info gui)

TornaxO7 added 3 commits

November 15, 2024 00:19


          remove unused constant

6f9146d


          fix doc

e4d9c38


          Merge branch '91-x11-backendcreate_screenshots-creates-blank-screensh…

b8a9e9b

…ots' of github.com:eneoli/flakeshot into 91-x11-backendcreate_screenshots-creates-blank-screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet