Skip to content

Conversation

@felixwalberg
Copy link
Contributor

Restored the scale to 1.0 for the assets in the Champ intro scene. This was inspired by #1835, trying to get ahead of issues where learners don't know the appropriate pixel size for creating art.

When creating this scene, I wasn't thinking specifically about asset ratios and pixel sizes. My poster assets are 125 x 170. Is this sufficient for learners? I know this is not a standard size.

On the other hand, the "Replace Image" asset is not set to a 1x scale, as the original asset was not the same aspect ratio as my images. Will this pose a problem?

@felixwalberg felixwalberg added this to the Vermont Cup StoryQuest milestone Jan 20, 2026
@felixwalberg felixwalberg requested review from a team as code owners January 20, 2026 23:22
@github-actions
Copy link

Play this branch at https://play.threadbare.game/branches/endlessm/champ-intro-asset-scaling.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@wjt
Copy link
Member

wjt commented Jan 21, 2026

Before After
image image

@wjt
Copy link
Member

wjt commented Jan 21, 2026

I don't think the exact size matters one way or another. If someone wants to draw a poster at a different size, they get to adjust the scene accordingly. (Or rather, whomever adds the asset in order to show judges what the team has done will either scale the asset, or leave it looking a bit janky.)

I do think it would be kinder to have all four images be the same size & scaled at 100%. So personally I would resize your copy of the "replace image" image to match your other posters.

Copy link
Member

@wjt wjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to either merge as-is or update the fourth image file.

@felixwalberg
Copy link
Contributor Author

Updated the fourth placeholder image to match the other images with 100% scale.

@felixwalberg felixwalberg merged commit 66486d9 into main Jan 21, 2026
5 checks passed
@felixwalberg felixwalberg deleted the champ-intro-asset-scaling branch January 21, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants