Skip to content

Conversation

@felixwalberg
Copy link
Contributor

Added a talker.tscn scene to the sequence puzzle mini-game. Created a unique dialogue file linked to the talker and replaced the dialogue with Champ-specific lore. "Dulled" out the NPC by removing some color and added a subdirectory for learners to access the dialogue file and NPC sprite frames. This addresses the requested changes from #1814.

@wjt is this appropriate for a dialogue placeholder? Neither the (depreciated) talker scene nor the new version you depicted in the issue has an editable text field in the inspector to change the dialogue, but I explicitly added to the dialogue where to find the file so that the learners can make changes.

Game Design:
Creativity & Design Thinking by @felixwalberg

@felixwalberg felixwalberg added this to the Vermont Cup StoryQuest milestone Jan 20, 2026
@felixwalberg felixwalberg requested review from a team as code owners January 20, 2026 22:35
@github-actions
Copy link

Play this branch at https://play.threadbare.game/branches/endlessm/champy-lore-scrolls.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@wjt
Copy link
Member

wjt commented Jan 21, 2026

Neither the (depreciated) talker scene nor the new version you depicted in the issue has an editable text field in the inspector to change the dialogue, […]

Select the talker node and click this in the inspector:

image

Game Design: Creativity & Design Thinking by @felixwalberg

When you're submitting small changes that are your own solo work, don't feel you need to add this each time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the learner_edits folder is a good idea, but only if you consistently use it for assets that contestants are expected to edit (c.f. #1468 (comment)). Personally I think it would be more consistent with the rest of the project to either place these files directly into scenes/quests/story_quests/champ/3_sequence_puzzle (as is done for all the other assets etc. in this scene) or in a components subfolder (as you have mostly done for the other scenes)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, I was thinking I would have to make that change for other mini-games for it to make sense. I am happy to go with whatever convention makes it the easiest for the learners. My concern was that the number of files in this mini-game subdirectory was getting to be overwhelming.

I think also seeing that from the inspector, you can click the dropdown on the dialogue and then "edit" rather than having to navigate the file system makes it more straightforward than I had previously thought.

I can wait on this until you hear back from Justin on the best format.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the inspector, you can click the dropdown on the dialogue and then "edit" rather than having to navigate the file system

You don't need to right-click. If you left-click it you are taken to the edit view. (At least that's how it's always worked for me.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this works! Very straightforward.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgbourque thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants