Open
Conversation
According to the Desktop Notifications Specification. See emersion#541
Owner
|
Hm, the way I've read the spec, the "transient" bit meant that the notification is not stored on disk (and restored), but history sounded unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft implementation for #541, implements handling of the "transient" hint according to the Desktop Notifications Specification.
The
-e/--transientflag ofnotify-send(libnotify) allows a simple test:While users are still able to explicitly put notifications in the history when calling
makoctl dismiss(without--no-history) or using the according binding (MAKO_BINDING_DISMISSinstead ofMAKO_BINDING_DISMISS_NO_HISTORY).Second commit is some kind of a clean-up, as it doesn't make much sense, IMHO to maintain both, a transient member and a (no-)history parameter.