Skip to content

implement mininum width for notification#509

Open
sewnie wants to merge 1 commit intoemersion:masterfrom
sewnie:master
Open

implement mininum width for notification#509
sewnie wants to merge 1 commit intoemersion:masterfrom
sewnie:master

Conversation

@sewnie
Copy link

@sewnie sewnie commented Mar 22, 2024

fixes #69

@sewnie
Copy link
Author

sewnie commented May 28, 2024

@emersion ?

@sewnie
Copy link
Author

sewnie commented Jul 27, 2024

@emersion ?

1 similar comment
@sewnie
Copy link
Author

sewnie commented Sep 13, 2024

@emersion ?

Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really wrap my head around what this is doing, but it seems like the existing width setting is now ignored?

The original issue is about max-width, and this PR seems to be implementing something else?

@sewnie
Copy link
Author

sewnie commented Mar 16, 2025

The original issue is about max-width, and this PR seems to be implementing something else?

Author wrote:

I use both long and short notification in terms of line lenght. I can set width but that's looking ugly for short notification.

In this PR, width will act as the maximum width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let us set max width. *feature request*

2 participants