Hints: Support 'sound-file' and 'sound-name' hints in makoctl list#470
Draft
earboxer wants to merge 3 commits intoemersion:masterfrom
Draft
Hints: Support 'sound-file' and 'sound-name' hints in makoctl list#470earboxer wants to merge 3 commits intoemersion:masterfrom
earboxer wants to merge 3 commits intoemersion:masterfrom
Conversation
Author
|
Should probably add a "suppress-sound" BOOLEAN criteria... not sure how widely used any of these are. Dino at least sends To improve the user-experience, maybe there should be an 'on-dismiss' binding, because I want to kill the sound AND close the notification. (And probably the actions should work with this... not sure if that would be possible to script. maybe I'm asking too much of mako at this point.) |
Author
|
If we implement "truthy/falsey" string comparisons first as in #471, then it will be easier to specify the config: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: https://specifications.freedesktop.org/notification-spec/latest/ar01s08.html
Added sound-file and sound-name to the data so they'll appear in makoctl list. Also added a criteria for sound-name.
You can use this config to play the sounds:
Closes #424
Testing notes: