Skip to content

RFC: Fix leaks of mako_notification in handle_notify()#379

Open
psqli wants to merge 1 commit intoemersion:masterfrom
psqli:master
Open

RFC: Fix leaks of mako_notification in handle_notify()#379
psqli wants to merge 1 commit intoemersion:masterfrom
psqli:master

Conversation

@psqli
Copy link
Contributor

@psqli psqli commented Aug 24, 2021

Unify clean up on error with goto statements.

Is freeing the expected behavior?

Unify clean up on error with goto statements.
@psqli
Copy link
Contributor Author

psqli commented Aug 24, 2021

Also, the commit 4dc382e ("Allow create_notification outside handle_notify") introduced strdup() calls inside reset_notification(), which is called by destroy_notification() just before notif is freed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant