Skip to content

feat(ld-file-upload): add file upload component #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
leabarth wants to merge 42 commits into
base: main
Choose a base branch
from
Draft

feat(ld-file-upload): add file upload component #861

leabarth wants to merge 42 commits into from

Conversation

@leabarth
Copy link
Contributor

@leabarth leabarth commented Jul 28, 2023 •
edited
Loading

Description

Fixes #(issue)

Type of change

  • Feature

Is it a breaking change?

  • Yes
  • No

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jul 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquid ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 7:52pm

@leabarth leabarth force-pushed the feat/ld-file-upload branch from 1a1c029 to 85b3dc2 Compare July 28, 2023 15:16
borisdiakur
borisdiakur reviewed Nov 14, 2023
View reviewed changes
src/liquid/components/ld-file-upload/ld-file-upload.tsx
this.cannotBeChosen = []
this.exceedMaxSize = []
for (let i = 0; i < chosenFiles.length; i++) {
if (
Copy link
Contributor

@borisdiakur borisdiakur Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use a Set or a Map here in order to improve performance and readability.

borisdiakur
borisdiakur reviewed Nov 15, 2023
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@borisdiakur borisdiakur borisdiakur left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leabarth @borisdiakur