Allow virtualization to set up link click listeners#137
Open
lydell wants to merge 1 commit intoelm:masterfrom
Open
Allow virtualization to set up link click listeners#137lydell wants to merge 1 commit intoelm:masterfrom
lydell wants to merge 1 commit intoelm:masterfrom
Conversation
ahankinson
added a commit
to elm-janitor/browser
that referenced
this pull request
Nov 21, 2025
fixes elm#137 fixes elm#105 fixes elm/virtual-dom#187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105 together with elm/virtual-dom#187
The code already sets
__VirtualDom_divertHrefToAppbefore each render, so that<a>elements created during the render can get a click listener that directs the link click to theupdatefunction, letting it decided what should happen. https://github.com/elm/browser/blob/1.0.2/src/Elm/Kernel/Browser.js#L81-L87This PR also sets
__VirtualDom_divertHrefToAppbefore virtualization, so that<a>HTML elements that are picked up by Elm during initialization also can get their click listener – which is implemented in elm/virtual-dom#187.Note to those following along: This PR is included in https://github.com/lydell/browser/tree/safe, which is part of https://github.com/lydell/elm-safe-virtual-dom.