Conversation
A dimensional analysis would have shown this to be incorrect; per is the period over which the rate value is applied and so should be in s, but this makes it in s², giving a rate in s¯².
efd6
force-pushed
the
117-dimensionally-wrong
branch
from
8a6b819 to
ff274f8
Compare
kcreddy
approved these changes
Jan 21, 2026
efd6
added a commit
to efd6/beats
that referenced
this pull request
Jan 21, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling. ref: elastic/mito#119
6 tasks
efd6
added a commit
to efd6/beats
that referenced
this pull request
Jan 21, 2026
This picks up elastic/mito@d017a1f which fixes rate period scaling. ref: elastic/mito#119
6 tasks
efd6
added a commit
to efd6/beats
that referenced
this pull request
Jan 21, 2026
This picks up elastic/mito@d017a1f which fixes rate period scaling. ref: elastic/mito#119
5 tasks
efd6
added a commit
to elastic/beats
that referenced
this pull request
Jan 23, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling. ref: elastic/mito#119
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
Jan 23, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling. ref: elastic/mito#119 (cherry picked from commit c17c95d) # Conflicts: # NOTICE.txt # docs/reference/filebeat/filebeat-input-cel.md # go.mod # go.sum
6 tasks
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
Jan 23, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling. ref: elastic/mito#119 (cherry picked from commit c17c95d) # Conflicts: # go.mod
6 tasks
cmacknz
pushed a commit
to elastic/beats
that referenced
this pull request
Jan 23, 2026
This picks up elastic/mito@d017a1f which fixes rate period scaling. ref: elastic/mito#119
efd6
added a commit
to elastic/beats
that referenced
this pull request
Jan 24, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling. ref: elastic/mito#119 (cherry picked from commit c17c95d)
efd6
added a commit
to elastic/beats
that referenced
this pull request
Jan 24, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling. ref: elastic/mito#119 (cherry picked from commit c17c95d)
efd6
added a commit
to elastic/beats
that referenced
this pull request
Jan 24, 2026
…#48526) This picks up elastic/mito@cf9d7cc which fixes rate period scaling. ref: elastic/mito#119 (cherry picked from commit c17c95d) --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6
added a commit
to elastic/beats
that referenced
this pull request
Jan 25, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling. ref: elastic/mito#119 (cherry picked from commit c17c95d) Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dimensional analysis would have shown this to be incorrect; per is the period over which the rate value is applied and so should be in s, but this makes it in s², giving a rate in s¯².
Please take a look.
Fixes #117.