Improve performance with efficient use of FieldMappingCache#389
Open
V1NAY8 wants to merge 2 commits intoelastic:mainfrom
Open
Improve performance with efficient use of FieldMappingCache#389V1NAY8 wants to merge 2 commits intoelastic:mainfrom
V1NAY8 wants to merge 2 commits intoelastic:mainfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
jenkins test this please |
55cecce to
727ddbe
Compare
727ddbe to
bcae8f4
Compare
bcae8f4 to
534b6ed
Compare
Contributor
|
jenkins test this please |
Contributor
Author
|
Ok, So, the tests are good. So, a simple rebase should be fine. |
534b6ed to
ba97ee4
Compare
ed80b7f to
9c9a8fc
Compare
Contributor
|
jenkins test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change will improve the performance of
FieldMappingCacheExisting drawbacks:
field_mapping_cacheis initialized on every yield ofitertuplesanditerrowsrepr()orprint()thefield_mapping_cacheis re initialized on every call.Now,
field_mapping_cacheis initialized once perquery_compiler, that too only when ETL such asto_pandas()oritertuplesoriterrowsorrepr()orprint()is done.Also, by default
scripted_fieldsare considered as "object". Previously we were finding source field, then if it's not source field, an exception is raised and then its data type is assigned as "object".This also improves the readability of code.
@sethmlarson Take a look :)