Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
c22fcd3 to
f1d7824
Compare
|
Added tests, updated |
sethmlarson
left a comment
There was a problem hiding this comment.
Thanks, few comments for you
|
Yep @sethmlarson , Made changes, |
|
I'll handle the elasticsearch-py stuff, there's a subtle change that needs to be made regarding which elasticsearch-py version to install |
|
Ask jenkins to test this please |
|
jenkins test this please |
|
Also I took reference for ipython check from |
|
@sethmlarson Anything else required on this change? |
Closes #294
Added tqdm functionality for
pandas_to_eland()If we want the progress bar to disappear we will need to just add
leave=Falseto tqdm context manager at line 234@sethmlarson
Please review if the implementation is correct, I will add notebook tests for this once review is done. 😃