feat: Switch to stable Rust and update rust-seq2kminmers dependency#23
Open
MrTomRod wants to merge 2 commits intoekimb:masterfrom
Open
feat: Switch to stable Rust and update rust-seq2kminmers dependency#23MrTomRod wants to merge 2 commits intoekimb:masterfrom
MrTomRod wants to merge 2 commits intoekimb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
mapquikto use stable Rust and switches therust-seq2kminmersdependency to the MrTomRod/rust-seq2kminmers fork (see rchikhi/rust-seq2kminmers#5), which supports stable Rust.Users can now build and run
mapquikwith justcargo build --release.Key Changes:
mapquiknow builds and runs on the stable toolchain.rust-seq2kminmersdependency to use the my fork, which replaces unstable intrinsics with stable equivalents.0.1.1to reflect these changes.Why?
Without these changes, I was unable to build mapquik.
I did not do enough testing. Please perform some sanity checks before merging.