-
Notifications
You must be signed in to change notification settings - Fork 55
Multi sensitive volume clusters #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ybedfer
wants to merge
12
commits into
main
Choose a base branch
from
Multi-SensitiveVolume-Clusters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+836
−340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstructors.
- "5SensVolumes" are designed for a 2D-strip readout, via "MPGDTrackerDigi".
- Modified constructors provide for both standard and "5SensVolumes".
- OuterBarrel constructor:
+ Simplified: providing now for only one <module> and one <layer> tag.
+ Sensisitive DetElement: in line with other constructors ("volSurfaceList",...).
…dicated configuration. - Simplication: Standard XML (almost-)free of any reference to strips. - Dedicated "craterlake_tracking_only_2DStrip" implementing "2DStrip" XMLs.
…PIXEL". - 2 flavours of Barrel MPGDs implemented in 2 distinct XMLs: "_pixel"/"_2DStrip". - "-DMPGD_INSTALL_PIXEL" allows to install "_pixel" instead of default "_2DStrip".
…xisting files in "install" directory. - "_pixel" by default: so that the PR checks run successfully even when the new version of "MPGDTrackerDigi" (see "eic/EICrecon#2177") is not in place. - Pre-existing files explicitly erased: since the cmake command "install" does not overwrite existing files.
for more information, see https://pre-commit.ci
…trip configurations.
Contributor
Author
|
This is the last one of a sequence of 4 PRs:
None of the above changes the default behavior (except for a slight modification of the cov. matrix in the current UV-segmentation implementation of the OuterBarrel). Would remain to have a last |
…m XML. - 2DStrip: + CyMBaL: v2.1 is the 5-SUBVOLUME version, v2.2 is clusterisation compatible. + Outer: same thing w/ v1.1 and v1.2. - StripID: Merge in #767a3c7a0 of branch Multi-SensitiveVolume-MPGD.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: barrel
Mid-rapidity detectors
topic: forward
Positive-rapidity detectors (hadron-going side)
topic: tracking
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Implement realistic pitch into Multi-SensitiveVolume-MPGD, extending PR##1014.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Eventually yes.