Open
Conversation
…tions Localise some more notification/updater strings
Addresses concerns in #36193 (comment) (excluding the last part, that is too involved and I can't imagine any workaround for it due to how strict the `Dropdown` structure is). Also adds truncation/padding to header label and search bar. Preview: https://github.com/user-attachments/assets/8885cb90-44dc-42ee-af21-cb33f7723e63
Use new song select (v2) for playlists
…rovided provider property The property used here is listed in SignalR documentation: https://learn.microsoft.com/en-us/aspnet/core/signalr/authn-and-authz?view=aspnetcore-10.0#bearer-token-authentication While in practice this probably has zero bearing on anything, theoretically the way proposed in this commit is more correct. As the documentation states, with some transports the token may need to be renewed if it expires, which providing it via a header as done previously would not achieve, while going through `API.AccessToken` every time will perform a token refresh if one is needed.
Clean-up from an old change (see #28892 (comment)).
More clean-up.
Clean up `HubClientConnector` configuration
Should've been true by default, minor mistake from a previous PR.
Used for "confine mouse mode" dropdown tooltip text.
Background blur is disabled by default.
Update form button UI/UX and support text wrapping
Closes #33395 Copies the bookmarks from `referenceWorkingBeatmap` while creating a new difficulty from scratch. I adapted the tests in `TestSceneEditorBeatmapCreation` to include the bookmark checks. --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
Resolves #36288. If the current selection is still available after leaving scoped mode, it's left as is. If it's not, the selection from before entering scoped mode is restored. https://github.com/user-attachments/assets/b1ac3de1-7c7f-4949-82a9-1dd0459f3f61 --------- Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
…lected object is changed (#36681) Before: https://github.com/user-attachments/assets/d0a0373d-2d46-48a9-9ea5-bac82a612f32 After: https://github.com/user-attachments/assets/f5785b54-d7fc-4ce0-86b0-60c96ff22bc3 --- Closes #36677. Kinda shocking this went by unnoticed for this long.
In stable, there was support for mixed fonts (some coming from the user's skin, with fallback missing characters generated from TTF backend). We don't really have support for this so this is a simple in-between for the time being.
Matches closer to stable spec.
Fix legacy key counter not using skin's font
Of note, this test scene still doesn't use the new footer properly. Should these even be here? Maybe it's better to leave these real world flows to a `Navigation` style test so we're not dealing with weird test setups that kinda do something but don't... or maybe do it in three different ways (two footers present, three back buttons etc.) Dunno. But this kind of covers what I want (except it doesn't cover the new footer usage).
Add ability for `LoadingLayer` to block all keyboard input
- The mods button should not be visible because it is not hooked up properly to actually work with selecting user mods. As written it would show (and feign the ability to modify) required mods on the playlist item. You could probably adjust the logic to make user mods controllable via this button but this is simpler for now. - The random and options buttons could perhaps remain, but they are of very limited use on this screen anyway. The previous iteration disabled all footer buttons altogether, so I'm just following precedent here mostly.
Migrate playlist freestyle select screen to use `SongSelectV2`
Migrate multiplayer freestyle select screen to use `SongSelectV2`
…o stable (#36702) - Closes #30293 - Fixes https://osu.ppy.sh/community/forums/topics/2179339?n=1 Aside from fixing the off-by-one error that I mentioned in #30293 (comment), this also: - Brings back the behaviour wherein if timing points are arranged very weird and nightcore would play e.g. two first beats in a timing point back-to-back, the second timing point is silent. - Brings back the behaviour wherein the finish sample only plays if `OmitFirstBarLine` on the timing point is disabled. However: - This does not bring back the behaviour wherein hat samples only play if the slider tick rate is even because that only kind of makes sense in common time, and if common time is mixed with waltz time or other time signatures, it just gets weird. - Also stable has zero attempt for compensating for waltz time anyway, lazer's behaviour is bespoke, so that is not going to match any way you cut it. My testing procedure essentially consisted of getting stable to log when it was playing nightcore samples and cross-checking the first 30sec or so of https://osu.ppy.sh/beatmapsets/534385#osu/1131956 (check out the timing of that beatmap, for something ranked it is DEEPLY messed up). I guess I can add test cases if deemed required but I already wasted much more time than I would have liked here...
…36729) - Fixes #36727 Copies/sets the non-maximised edge effect initially: https://github.com/ppy/osu/blob/c144cf188a37ebc965b25818938527c02013efc4/osu.Game/Screens/OnlinePlay/Multiplayer/Spectate/PlayerGrid.Cell.cs#L83-L88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )