Open
Conversation
|
Build failed.
|
dtantsur
requested changes
Dec 1, 2019
| @@ -0,0 +1,58 @@ | |||
| // Copyright 2018 Dmitry Tantsur <divius.inside@gmail.com> | |||
Owner
There was a problem hiding this comment.
Put your copyright here or just skip the copyright completely.
| @@ -0,0 +1,190 @@ | |||
| // Copyright 2017 Dmitry Tantsur <divius.inside@gmail.com> | |||
| /// Start creating a server. | ||
| pub(crate) fn new(session: Rc<Session>, name: String) -> NewStack { | ||
| NewServer { | ||
| // session, |
Owner
There was a problem hiding this comment.
yeah, you surely need it on line 60
|
recheck |
|
Build failed.
|
|
Hi, I need the Orchestration API feature and I can probably implement it. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm starting to add the OpenStack Orchestration (Heat) API. It's far from finished (I need to add src/orchestration/api.rs before it even compiles) but I wanted to open a PR to allow early feedback/others to contribute.