issue 1 solution i.e. align image of paper#5
Open
Abhinav-2901 wants to merge 2 commits intodscnsec:mainfrom
Open
issue 1 solution i.e. align image of paper#5Abhinav-2901 wants to merge 2 commits intodscnsec:mainfrom
Abhinav-2901 wants to merge 2 commits intodscnsec:mainfrom
Conversation
Member
|
This works great. Now could you make a jupyter notebook submission for this code with proper documentation of why you used what. Be sure to include all references from where you took help. |
Author
|
Sure I'll do that.
Can you share the deadline with me?
…On Tue, 22 Dec, 2020, 11:42 pm Rishiraj Acharya, ***@***.***> wrote:
This works great. Now could you make a jupyter notebook submission for
this code with proper documentation of why you used what. Be sure to
include all references from where you took help.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP5OFVHSD7ZGBXDTXV53ZDTSWDOR7ANCNFSM4VCK7FLQ>
.
|
Author
I have push the python notebook with step by step execution the algorithm. |
Author
|
I have pushed the jupyter notebook with step by step execution of the
algorithm with the images of all the output at each step in the previous
branch itself.
Do review it and let me know the Changes that needs to be done.
On Tue, 22 Dec, 2020, 11:46 pm Abhinav Chauhan, <abhinavcj29@gmail.com>
wrote:
… SureI I'll do that.
Can you share the deadline with me?
On Tue, 22 Dec, 2020, 11:42 pm Rishiraj Acharya, ***@***.***>
wrote:
> This works great. Now could you make a jupyter notebook submission for
> this code with proper documentation of why you used what. Be sure to
> include all references from where you took help.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#5 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AP5OFVHSD7ZGBXDTXV53ZDTSWDOR7ANCNFSM4VCK7FLQ>
> .
>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My idea to overcome this issue is by reordering the the detected corner points of the greatest contour detected so that we can provide those corner points in the correct order for wraping.
I have created a reorder function in my python file.
I used simple numpy library and some basic maths to do that.
Refrence taken from Murtaza's Workshop (Youtube channel)