Hi! I fixed some code for you! #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Won't this break compat with node < 0.8? |
Owner
|
That is, shouldn't it be: |
|
I'm not sure how to attach a commit to this issue directly. My fix is part of this pull request, and it indeed does as you consider @dsc, it uses (fs.exists || path.exists) to avoid breaking older node versions: |
|
we need this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I am migrationBot!
Did you know that
path.{exists,existsSync}was moved tofs.{exists,existsSync}, and thattty.setRawMode(mode)was moved totty.ReadStream#setRawMode()(i.e.process.stdin.setRawMode()) in node v0.8.0? Read more @API changes between v0.6 and v0.8I automatically made some changes I think will help you migrate your codebase to node v0.8.0, please review these changes and merge them if you feel they are useful, If they are not you can ignore this Pull Request.
Have a Nice Day!
--migrationBot