Fix invalid exception syntax: use tuple instead of list in HashRedactor#356
Open
Nepomuk5665 wants to merge 1 commit intodropbox:mainfrom
Open
Fix invalid exception syntax: use tuple instead of list in HashRedactor#356Nepomuk5665 wants to merge 1 commit intodropbox:mainfrom
Nepomuk5665 wants to merge 1 commit intodropbox:mainfrom
Conversation
The except clause at line 714 in HashRedactor.apply() was using list syntax [AttributeError, ValueError] instead of tuple syntax (AttributeError, ValueError). Using a list causes a TypeError at runtime: 'catching classes that do not inherit from BaseException is not allowed'. This bug would prevent the HashRedactor from properly catching AttributeError or ValueError, causing the redaction to fail entirely when these exceptions occur.
|
Thanks for your submission! I'll pass this along to the team for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in
stone/backends/python_rsrc/stone_validators.pywhere an except clause was using list syntax instead of tuple syntax for catching multiple exceptions.The Bug
On line 714, the code was:
This is invalid Python syntax. When Python attempts to execute this code, it raises:
The Fix
Changed to proper tuple syntax:
Verification
Impact
This bug would cause
HashRedactor.apply()to fail entirely whenever anAttributeErrororValueErroris raised during hashing, preventing proper redaction of sensitive data.