[#1968] Added VORTEX_PROVISION_FALLBACK_TO_PROFILE flag to provision script.#2294
Open
AlexSkrypnyk wants to merge 1 commit intomainfrom
Open
[#1968] Added VORTEX_PROVISION_FALLBACK_TO_PROFILE flag to provision script.#2294AlexSkrypnyk wants to merge 1 commit intomainfrom
VORTEX_PROVISION_FALLBACK_TO_PROFILE flag to provision script.#2294AlexSkrypnyk wants to merge 1 commit intomainfrom
Conversation
WalkthroughAdds Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ProvisionScript as Provision Script
participant DBDump as DB Dump (file)
participant DBImage as DB Image (container)
participant Profile as Profile Installer
User->>ProvisionScript: start provisioning (type=database)
ProvisionScript->>DBDump: check for dump file
alt dump exists
ProvisionScript->>DBDump: restore dump
ProvisionScript->>User: success
else dump missing
ProvisionScript->>DBImage: check for DB image
alt image exists
ProvisionScript->>DBImage: attempt import
alt import ok
ProvisionScript->>User: success
else import fails
alt VORTEX_PROVISION_FALLBACK_TO_PROFILE = 1
ProvisionScript->>Profile: install from profile
ProvisionScript->>User: success (fallback)
else
ProvisionScript->>User: fail (corrupt/missing DB)
end
end
else image missing
alt VORTEX_PROVISION_FALLBACK_TO_PROFILE = 1
ProvisionScript->>Profile: install from profile
ProvisionScript->>User: success (fallback)
else
ProvisionScript->>User: fail (no dump/image)
end
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
Verify each finding against the current code and only fix it if needed.
In @.vortex/docs/content/drupal/provision.mdx:
- Around line 153-159: Update the VORTEX_PROVISION_FALLBACK_TO_PROFILE
description to explicitly state that the fallback is only evaluated when
VORTEX_PROVISION_TYPE is set to "database" (i.e., it will not trigger when
VORTEX_PROVISION_TYPE=profile); modify the prose for that bullet so it reads
that fallback to installing from profile occurs only if the provisioning type is
database and the DB dump or image is unavailable, to avoid confusion for users
who set VORTEX_PROVISION_TYPE=profile.
Member
Author
|
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Member
Author
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2294 +/- ##
==========================================
- Coverage 77.49% 77.12% -0.38%
==========================================
Files 117 110 -7
Lines 6164 6015 -149
Branches 44 0 -44
==========================================
- Hits 4777 4639 -138
+ Misses 1387 1376 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlexSkrypnyk
force-pushed
the
feature/1968-provision-fallback
branch
from
baeb1ab to
2109a95
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.vortex/docs/content/development/variables.mdx:
- Line 392: Update the VORTEX_PROVISION_FALLBACK_TO_PROFILE doc entry to
explicitly state it is a boolean expecting values "1" (enabled) and "0"
(disabled), and clarify that when the variable is unset the default behavior is
disabled (effectively treated as "0"); reference the variable name
VORTEX_PROVISION_FALLBACK_TO_PROFILE and the related usage in .env and
scripts/vortex/provision.sh so readers know where it is configured and consumed.
---
Duplicate comments:
In @.vortex/docs/content/drupal/provision.mdx:
- Around line 153-159: Update the VORTEX_PROVISION_FALLBACK_TO_PROFILE
description to explicitly state that the fallback is evaluated only during
database-based provisioning (i.e., when VORTEX_PROVISION_TYPE is not set to
"profile" or when importing a DB dump/container image); reword the line for
VORTEX_PROVISION_FALLBACK_TO_PROFILE so it clarifies it will only trigger when
attempting to provision from a database dump or image and not when
VORTEX_PROVISION_TYPE=profile, referencing the
VORTEX_PROVISION_FALLBACK_TO_PROFILE and VORTEX_PROVISION_TYPE variables and
ensuring the example phrasing signals the conditional behavior.
Member
Author
|
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Member
Author
|
AlexSkrypnyk
force-pushed
the
feature/1968-provision-fallback
branch
from
2109a95 to
c0b14e3
Compare
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.vortex/docs/content/drupal/provision.mdx:
- Around line 154-159: Update the prose for VORTEX_PROVISION_FALLBACK_TO_PROFILE
to explicitly state that the fallback behavior only applies when
VORTEX_PROVISION_TYPE is set to "database" (i.e., when you intended to import a
DB dump); clarify that if VORTEX_PROVISION_TYPE=profile the fallback is
irrelevant, and keep the current explanation about falling back to profile when
the database dump or image is unavailable. Reference
VORTEX_PROVISION_FALLBACK_TO_PROFILE and VORTEX_PROVISION_TYPE in the sentence
so readers who skip the flow diagram see the constraint.
Member
Author
|
|
Member
Author
|
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1968
Summary by CodeRabbit
New Features
Documentation
Tests