Moved MetaTag trait to the root namespace.#523
Conversation
WalkthroughMetatagTrait is moved from the Drupal-specific namespace ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@STEPS.md`:
- Around line 1272-1277: The blockquote under the MetatagTrait heading has extra
spaces after the '>' and the following list items are mis-indented; update the
blockquote line (the line starting with "> Assert `<meta>` tags in page
markup.") to use a single space after '>' ("> Assert ...") and normalize the
unordered list indentation so each list item is consistently indented (use a
single level of indentation, e.g., two spaces) to satisfy markdownlint rules
MD027 and MD007; ensure the heading "MetatagTrait" and references to [Source]
and [Example] remain unchanged.
In `@tests/behat/features/metatag.feature`:
- Line 13: Add a descriptive tag (e.g., `@metatag`) to the feature/scenario tags
so tests can be run selectively; update the existing tag line that currently
contains "@trait:MetatagTrait" in tests/behat/features/metatag.feature (and the
similar occurrence at the other location around line 36) to include "@metatag"
alongside the current tags (e.g., "@metatag `@trait`:MetatagTrait" or add a
separate "@metatag" tag on the same block) so runners can target these tests
directly.
| ## MetatagTrait | ||
|
|
||
| [Source](src/MetatagTrait.php), [Example](tests/behat/features/metatag.feature) | ||
|
|
||
| > Assert `<meta>` tags in page markup. | ||
| > - Assert presence and content of meta tags with proper attribute handling. |
There was a problem hiding this comment.
Fix markdownlint blockquote spacing and list indentation.
markdownlint flags MD027/MD007 here; adjust the blockquote to use single-space alignment and proper list indentation.
🔧 Proposed fix
-> Assert `<meta>` tags in page markup.
-> - Assert presence and content of meta tags with proper attribute handling.
+> Assert `<meta>` tags in page markup.
+> - Assert presence and content of meta tags with proper attribute handling.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## MetatagTrait | |
| [Source](src/MetatagTrait.php), [Example](tests/behat/features/metatag.feature) | |
| > Assert `<meta>` tags in page markup. | |
| > - Assert presence and content of meta tags with proper attribute handling. | |
| ## MetatagTrait | |
| [Source](src/MetatagTrait.php), [Example](tests/behat/features/metatag.feature) | |
| > Assert `<meta>` tags in page markup. | |
| > - Assert presence and content of meta tags with proper attribute handling. |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
1276-1276: Multiple spaces after blockquote symbol
(MD027, no-multiple-space-blockquote)
1277-1277: Unordered list indentation
Expected: 0; Actual: 1
(MD007, ul-indent)
1277-1277: Multiple spaces after blockquote symbol
(MD027, no-multiple-space-blockquote)
🤖 Prompt for AI Agents
In `@STEPS.md` around lines 1272 - 1277, The blockquote under the MetatagTrait
heading has extra spaces after the '>' and the following list items are
mis-indented; update the blockquote line (the line starting with "> Assert
`<meta>` tags in page markup.") to use a single space after '>' ("> Assert ...")
and normalize the unordered list indentation so each list item is consistently
indented (use a single level of indentation, e.g., two spaces) to satisfy
markdownlint rules MD027 and MD007; ensure the heading "MetatagTrait" and
references to [Source] and [Example] remain unchanged.
| | content | width | | ||
|
|
||
| @trait:Drupal\MetatagTrait | ||
| @trait:MetatagTrait |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider adding a descriptive tag (e.g., @metatag) for selective runs.
This helps targeted execution alongside @api/@trait. Based on learnings, add a descriptive tag where appropriate.
Also applies to: 36-36
🤖 Prompt for AI Agents
In `@tests/behat/features/metatag.feature` at line 13, Add a descriptive tag
(e.g., `@metatag`) to the feature/scenario tags so tests can be run selectively;
update the existing tag line that currently contains "@trait:MetatagTrait" in
tests/behat/features/metatag.feature (and the similar occurrence at the other
location around line 36) to include "@metatag" alongside the current tags (e.g.,
"@metatag `@trait`:MetatagTrait" or add a separate "@metatag" tag on the same
block) so runners can target these tests directly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 2351 2351
=========================================
Hits 2351 2351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Refactor
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.