Azure Split - Step 2 - New Files #3904

paulmedynski · 2026-01-20T19:52:31Z

Description

This PR contains the new Abstractions and Azure package files:

Added the new Abstractions and Azure source files and associated pipeline files.
Setup build.proj targets and default version numbers.
Standardized project CLS compliance.

PR series:

Azure Split - Step 1 - Prep Work #3902:
- Merge changes that aren't directly related to the Azure split work, but that setup the stage for that work.
Azure Split - Step 2 - New Files #3904:
- Merge new files and related changes that do not affect the existing MDS projects or artifacts.
[Draft] Azure Split - Step 3 - Tie Everything Together #3908:
- Merge the changes to MDS and pipelines that tie everything together.
Step 4:
- Any remaining tasks or cleanup.

Testing

Normal PR/CI pipeline runs will validate most changes.
Manual inspection of pipeline logs and artifacts will confirm some of the fiddly parts.

- Added the new Abstractions and Azure source files and associated pipeline files. - Setup build.proj targets and default version numbers. - Standardized project CLS compliance.

Copilot

Pull request overview

This pull request is Step 2 of the Azure split effort, adding new Abstractions and Azure extension packages to decouple Azure dependencies from the main Microsoft.Data.SqlClient package. The PR introduces two new packages with their source code, tests, documentation, and CI/CD pipeline configurations while standardizing CLS compliance across projects.

Changes:

Added new Microsoft.Data.SqlClient.Extensions.Abstractions package with base types for authentication and related abstractions
Added new Microsoft.Data.SqlClient.Extensions.Azure package containing Azure authentication implementations moved from MDS
Standardized CLS compliance by using AssemblyAttribute declarations instead of embedded assembly attributes
Added comprehensive CI/CD pipeline support for building and testing both new packages across multiple platforms

Reviewed changes

Copilot reviewed 69 out of 69 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
tools/targets/GenerateThisAssemblyCs.targets	Simplified to unconditionally generate ThisAssembly.cs with configurable namespace
tools/props/Versions.props	Added imports for Abstractions and Azure version properties
src/Microsoft.Data.SqlClient/tests/tools/TDS/*/.csproj	Removed ClsCompliant property (standardization)
src/Microsoft.Data.SqlClient/**/Microsoft.Data.SqlClient.csproj	Added CLS compliance via AssemblyAttribute
src/Microsoft.Data.SqlClient.sln	Added folder structure and projects for Abstractions and Azure packages
src/Microsoft.Data.SqlClient.Extensions/Abstractions/**	Complete Abstractions package with source, tests, and documentation
src/Microsoft.Data.SqlClient.Extensions/Azure/**	Complete Azure package with source, tests, and documentation
eng/pipelines/**	New CI/CD stages, jobs, and variables for building/testing new packages
build.proj	Added targets for building Abstractions and Azure packages
Directory.Packages.props	Added package version management for new packages
BUILDGUIDE.md	Updated documentation with new build targets

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderException.cs

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderInternal.cs

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

paulmedynski · 2026-01-20T19:57:56Z

eng/pipelines/common/templates/jobs/run-tests-package-reference-job.yml

    parameters:
      referenceType: Package
      buildConfiguration: Release
-      cleanFirst: true


The build.proj Clean target removes all generated files, including the packages/ directory. This is the behaviour we want from a Clean. However, removing packages/ causes restores to fail when we're using our local NuGet.config. This is mostly done in the pipelines, so we must remove the cleans here, which weren't doing anything useful anyway.

paulmedynski · 2026-01-20T19:59:14Z

eng/pipelines/libraries/build-variables.yml

 # See the LICENSE file in the project root for more information.                #
 #################################################################################

+# This file is only included in MDS OneBranch Official pipelines.


There are too many YAML variables and files. This will at least make it easier to reason about which variables affect which pipelines.

paulmedynski · 2026-01-20T20:00:36Z

eng/pipelines/dotnet-sqlclient-ci-core.yml


+  # Build the Abstractions package, and publish it to the pipeline artifacts
+  # under the given artifact name.
+  - template: /eng/pipelines/stages/build-abstractions-package-ci-stage.yml@self


This PR adds the new Abstractions and Azure packages to the pipelines, but MDS and its tests don't use them yet.

paulmedynski · 2026-01-20T20:05:14Z

src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs

 // NOTE: The current Microsoft.VSDesigner editor attributes are implemented for System.Data.SqlClient, and are not publicly available.
 // New attributes that are designed to work with Microsoft.Data.SqlClient and are publicly documented should be included in future.

-[assembly: System.CLSCompliant(true)]


We were setting CLS compliance several ways, so I standardized on the project approach.

paulmedynski · 2026-01-20T20:06:39Z

src/Microsoft.Data.SqlClient/tests/tools/TDS/TDS.Servers/TDS.Servers.csproj

    <AssemblyName>Microsoft.SqlServer.TDS.Servers</AssemblyName>
    <ProjectGuid>{978063D3-FBB5-4E10-8C45-67C90BE1B931}</ProjectGuid>
    <TargetFrameworks>netstandard2.0</TargetFrameworks>
-    <ClsCompliant>false</ClsCompliant>


There is no such MSBuild property, so this wasn't doing anything.

paulmedynski · 2026-01-20T20:07:59Z

src/Microsoft.Data.SqlClient.sln

 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Data.SqlClient.TestCommon", "Microsoft.Data.SqlClient\tests\Common\Microsoft.Data.SqlClient.TestCommon.csproj", "{3FF03FA9-E3C3-49E3-9DCB-C703A5B0278B}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Microsoft.Data.SqlClient.Extensions", "Microsoft.Data.SqlClient.Extensions", "{19F1F1E5-3013-7660-661A-2A15F7D606C1}"


I used dotnet sln add to add the new projects.

paulmedynski · 2026-01-20T20:08:55Z

tools/targets/GenerateThisAssemblyCs.targets

+      <ThisAssemblyNamespace Condition="'$(ThisAssemblyNamespace)' == ''">System</ThisAssemblyNamespace>
+
      <ThisAssemblyCsContents>
-[assembly: System.CLSCompliant(true)]


It's was too sneaky using this target to inject CLS compliance. Moving it to all of the relevant project files makes it clear and obvious.

paulmedynski · 2026-01-20T20:09:50Z

tools/targets/GenerateThisAssemblyCs.targets

      </ThisAssemblyCsContents>
    </PropertyGroup>

-    <!-- Get the last version number we built with (if any) -->


This was over-engineered - there's no need to attempt to avoid generating this file on every build.

paulmedynski · 2026-01-20T20:10:58Z

tools/targets/GenerateThisAssemblyCs.targets

    <PropertyGroup>
+
+      <!-- Put the ThisAssembly class in the System namespace by default. -->
+      <ThisAssemblyNamespace Condition="'$(ThisAssemblyNamespace)' == ''">System</ThisAssemblyNamespace>


This is now shared by 3 projects, and they all need to put this class in a unique namespace.

- Added ThisAssembly generation to Abstractions. - Fixed branch wildcards in PR pipeline and CodeQL workflow triggers.

- Fixed paratemer name typo.

- Fixed cyclic dependency.

Copilot

Pull request overview

Copilot reviewed 72 out of 72 changed files in this pull request and generated no new comments.

- Inhibited some Azure tests that won't pass yet. - Addressed Copilot comments in the PR.

codecov · 2026-01-21T17:14:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.92%. Comparing base (b5fafcb) to head (e4fdb36).

Additional details and impacted files

@@                   Coverage Diff                    @@
##           dev/paul/azure/step1    #3904      +/-   ##
========================================================
- Coverage                 69.96%   69.92%   -0.04%     
========================================================
  Files                       263      263              
  Lines                     66190    66190              
========================================================
- Hits                      46307    46285      -22     
- Misses                    19883    19905      +22

Flag	Coverage Δ
netcore	`69.91% <ø> (-0.05%)`	⬇️
netfx	`69.17% <ø> (-0.08%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 72 out of 72 changed files in this pull request and generated 3 comments.

src/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj

eng/pipelines/stages/build-azure-package-ci-stage.yml

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

- Addressed Copilot suggestions.

paulmedynski · 2026-01-21T20:09:26Z

.github/workflows/codeql.yml

 on:
  push:
-    branches: [ "main", "feat/*" ]
+    branches: [ "main", "feat/*", "dev/**/*" ]


This will permit the CodeQL workflow to run on pushes and PRs targeting main, any feature branch, and any dev branch.

paulmedynski · 2026-01-21T20:10:43Z

eng/pipelines/sqlclient-pr-package-ref-pipeline.yml

    include:
    # GitHub repo branch targets that will trigger PR validation builds.
-    - dev/*
+    - dev/**/*


This now correctly triggers PR pipeline runs for PRs targeting another dev branch.

paulmedynski · 2026-01-21T20:13:03Z

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

+        {
+            if (obj != null && obj is TokenCredentialKey tcKey)
+            {
+                return _tokenCredentialType == tcKey._tokenCredentialType


Copilot suggested a change here:

#3904 (comment)

Please review carefully, since it changes how the s_tokenCredentialMap dictionary performs key equality!

Task 41736: Merge feat/azure-split to main: Step 2 - New files

2d60931

- Added the new Abstractions and Azure source files and associated pipeline files. - Setup build.proj targets and default version numbers. - Standardized project CLS compliance.

Copilot AI review requested due to automatic review settings January 20, 2026 19:52

paulmedynski added the Area\Azure Connectivity Use this to tag issues that are related to Azure connectivity. label Jan 20, 2026

This was referenced Jan 20, 2026

[DO NOT MERGE] Visuazlie diffs of feat/azure split #3901

Draft

Azure Split - Step 1 - Prep Work #3902

Open

paulmedynski added this to the 7.0.0-preview4 milestone Jan 20, 2026

Copilot started reviewing on behalf of paulmedynski January 20, 2026 19:55 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

paulmedynski commented Jan 20, 2026

View reviewed changes

paulmedynski added 2 commits January 20, 2026 16:25

Task 41736: Merge feat/azure-split to main: Step 2 - New files

0660792

- Added ThisAssembly generation to Abstractions. - Fixed branch wildcards in PR pipeline and CodeQL workflow triggers.

Task 41736: Merge feat/azure-split to main: Step 2 - New files

ff42d1c

- Fixed paratemer name typo.

Copilot AI review requested due to automatic review settings January 21, 2026 11:10

Copilot started reviewing on behalf of paulmedynski January 21, 2026 11:10 View session

Task 41736: Merge feat/azure-split to main: Step 2 - New files

72795ae

- Fixed cyclic dependency.

Copilot AI reviewed Jan 21, 2026

View reviewed changes

Task 41736: Merge feat/azure-split to main: Step 2 - New files

2f62249

- Inhibited some Azure tests that won't pass yet. - Addressed Copilot comments in the PR.

paulmedynski marked this pull request as ready for review January 21, 2026 17:47

paulmedynski requested a review from a team as a code owner January 21, 2026 17:47

Copilot AI review requested due to automatic review settings January 21, 2026 17:47

paulmedynski changed the title ~~[DRAFT] Azure Split - Step 2 - New Files~~ Azure Split - Step 2 - New Files Jan 21, 2026

Copilot started reviewing on behalf of paulmedynski January 21, 2026 17:48 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

Task 41736: Merge feat/azure-split to main: Step 2 - New files

e4fdb36

- Addressed Copilot suggestions.

paulmedynski commented Jan 21, 2026

View reviewed changes

paulmedynski mentioned this pull request Jan 22, 2026

[Draft] Azure Split - Step 3 - Tie Everything Together #3908

Draft

Azure Split - Step 2 - New Files #3904

Are you sure you want to change the base?

Azure Split - Step 2 - New Files #3904

Conversation

paulmedynski commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

codecov bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

paulmedynski commented Jan 20, 2026 •

edited

Loading

codecov bot commented Jan 21, 2026 •

edited

Loading