adopt percentile aggregation so it copes with values >1000ms#1
Open
dothebart wants to merge 6056 commits intodothebart:masterfrom
Open
adopt percentile aggregation so it copes with values >1000ms#1dothebart wants to merge 6056 commits intodothebart:masterfrom
dothebart wants to merge 6056 commits intodothebart:masterfrom
Conversation
|
is there any update on this fix? we are also affected |
dothebart
pushed a commit
that referenced
this pull request
May 23, 2015
ceph: a couple of small details
… for the Turbostat and GPU NVidia plugins.
Re-format some lines to appease clang-format. clang-format also wants to change the indentation of some #endif comments I didn't introduce and re-order #include's into a form that /does not compile/.
Since Python 3.8 --embed flag needs to be provided to python-config to embed python. Reference: https://bugs.python.org/issue36721 This was partially addressed in #3170 but only fixed building and not linking with python.
This utility simplifies filtering and parsing specific messages from given log file. It tracks log file using utils_tail_match.h API. Main feature is automatic messages assembly based on set of user provided regular expressions containing distinguished expressions for recognizing start and the end of the message. That makes assembling single message from multiple log lines quite easy. Utility supports multiple parsing jobs and also user defined message part validation flags (mandatory or not). Added fixes for memory leak in utils_match.c and for debug mode segfault in src/utils_tail_match.c Modification of utils_tail and utils_tail_match API with adding option for reading file from the beginning. Minor modifications in this API calls in tail and tail_csv plugins. Change-Id: I6865833c8d5403294124187aa7f93cc957004a03 Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
Extend condition to ignore patterns before message has started and after it is completed. Change-Id: I2ea7fcc8c11bf3f41a21aa08b014faf6074d2234 Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
Large message buffer memory allocation that was needed for handling MCE message flood has significant performance impact on collectd CPU usage. This fix adds logic for decreasing message buffer size to default value (64) if there's nothing to parse. Change-Id: Ibbaef211e1fe24d53663d717a1899ec719017b2b Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
Add new possible value for submatch index: -1. For this value do not add the matched string to results. It can be used to only filter the required messages from syslog without adding the match to result. Change-Id: I93d9595be77427c135cc09baac901cd919d6c27e Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
utils_tail, utils_tail_match: Change _Bool to bool. utils_message_parser: Correct struct and type names, cleanup, unit tests. Change-Id: I40f3336e274f01791e7c171db5be2f21a6c9217c Signed-off-by: Mozejko, MarcinX <marcinx.mozejko@intel.com>
Change-Id: I193aa776d6fbc1e31690db96d85143707823fbe1 Signed-off-by: Mozejko, MarcinX <marcinx.mozejko@intel.com>
Change-Id: I9189751dd8e29047488d2f9634cb0856333436bf Signed-off-by: Adrian Boczkowski <adrianx.boczkowski@intel.com>
Empty <Plugin> section can be used to autoload plugin, which does not supports configuration callback.
daemon: Fix regression caused by #3217
move utils_* to src/utils minor doc fixes Change-Id: I287dff4639b2fa59418cac3e16093b240119f945 Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
Fix a few memory leaks on error paths in the amqp1 plugin. ChangeLog: amqp1 plugin: Fix leaks on error paths. Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
Add a missing freeaddrinfo on an error path to fix a memory leak in the network code. Changelog: network: Fix memory leak. Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
Trivia: this cost a user €1844,28160184475 in electricity (~3TB of RAM freed) Changelog: Fix memory leak in write_riemann Change-Id: If95da8d90c078c19ac0062e3bbb006185dcc441d
Fix memory leak in write_riemann
Fix linking with Python 3.8
Remove grpc from Mac builds for now
Signed-off-by: TG, Hari <hari.tg@intel.com>
… files is a valid C string.
amqp: allow multiple hosts for failover
Extracted from #3360
Add varnish 6 support
For example, this adds v0 and Transient for SMA, allowing to monitor cache size properly Fixes #2206
Add target in category for varnish 6
Add missing zk_last_proposal_size , zk_min_proposal_size and zk_max_proposal_size mntr fields (available since zk 3.5) to handled fields
Zookeeper - Add missing 3.5 mntr fields
After losing our connection to a MQTT broker our subscription will be gone, too, so we need to subscribe to our topic once again after reconnecting, otherwise collectd will not receive any MQTT messages anymore. Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
This is an automated code style fix generated by running "contrib/format.sh src/mqtt.c". No functional change intended. Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
MQTT: Resubscribe after a reconnect
collectd.conf(5): Document the format expected by "sensors"' ignore list.
write_sensu: add the IncludeSource option
types.db(5): Improve wording and document conventions.
mysql: report slave_io_running and slave_sql_running
write_http no longer writes http response to stdout
… names If HardwareEvents group consisted of events that can't be resolved collectd could crash. Change-Id: Ia66732037161bce5fbff73dc635eb40fd1ad8eed Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
intel_pmu: fix crash after specifying incorrect HardwareEvents
If machine has high number of CPUs or interrupts or both, the /proc/stat can easily grow over current buffer size 4kB. On my current machine (64 cores, ~300 interrupts) the /proc/stat has 12kB of data. And since the `procs_running` line is after the interrupts it is never read. Increasing the size to 64KB so it will accommodate even heavier machines.
processes: increase reading buffer for /proc/stat
Add client interface for the jolokia.org JMX client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plesae pick...
2b0eac1
to fix collectd#401