dev: decouple Abstract_Ability#4
Closed
justlevine wants to merge 1 commit intodkotter:feature/title-generation-basefrom
Closed
dev: decouple Abstract_Ability#4justlevine wants to merge 1 commit intodkotter:feature/title-generation-basefrom
justlevine wants to merge 1 commit intodkotter:feature/title-generation-basefrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
justlevine
commented
Nov 12, 2025
| */ | ||
| protected function category(): string { | ||
| return 'ai-experiments'; // TODO: add a reusable way to get the category slug? | ||
| public function __construct( \WordPress\AI\Features\Title_Generation\Title_Generation $feature ) { |
Author
There was a problem hiding this comment.
This can just as easily take an $id, $label, $description (or nothing and inverse the relationship) was just demonstrating how DI could look if there was a reason for an Ability and a Feature to be directly coupled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes
Illustrative example of an
Abstract_Abilityclass that is decoupled both fromAbstract_FeatureandWP_Ability.Why?
WordPress#61
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast