servername param added for Servername Indication#37
Open
iamrc90 wants to merge 1 commit intoditesh:masterfrom
Open
servername param added for Servername Indication#37iamrc90 wants to merge 1 commit intoditesh:masterfrom
iamrc90 wants to merge 1 commit intoditesh:masterfrom
Conversation
ToBiDi0410
approved these changes
Jan 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ditesh ,
Recently while working on Node 14, I faced an error with Gmail Accounts in production.
Referring to issue nodejs/node#28167 and from the node js documentation (https://nodejs.org/docs/latest-v14.x/api/tls.html), SNI ( server name identification ) needs to be passed when connecting to Gmail pop3 server, which used to be sent by default before node 12. I have passed the parameter
servernameto thetls.connect()method to fix my problem.You are requested to have a look at the PR and suggest if it can be merged.
Thanks